Skip to content

[#161980170] Removes 505 error for invalid user/parcel id#43

Merged
ipaullly merged 66 commits intodevelopfrom
bg-id-validation-161980170
Nov 15, 2018
Merged

[#161980170] Removes 505 error for invalid user/parcel id#43
ipaullly merged 66 commits intodevelopfrom
bg-id-validation-161980170

Conversation

@ipaullly
Copy link
Owner

@ipaullly ipaullly commented Nov 15, 2018 •
edited
Loading

What does this PR do?

catches the instances where a user may submit a wrong id when canceling or retrieving orders by a specific user_id

Description of Task to be completed?

  • Define a method in parcels model to check whether id passed into it exists in the database
  • add logic to view functions to raise an error message when invalid id is passed through the URL

How should this be manually tested?

access the API documentation at https://documenter.getpostman.com/view/4014888/RzZCCwun, press the Run in Postman at the top right corner of the window. Try to send the endpoints that require a user/parcel id with an invalid id and an error message appears promptly

ipaullly added 30 commits November 6, 2018 02:30
@ipaullly
[starts #161737782] build model and view for parcels POST api
ea6da11
@ipaullly
[starts #161748253] Create GET delivery order list
26d0031
@ipaullly
[starts #161766269]Build API to retrieve single order
67006a9
@ipaullly
[finishes #161766269] Add class and methods docstrings
37f0d14
@ipaullly
[starts #161773293] write passing test for POST new parcel order
534a2b9
@ipaullly
[starts #161773596] write test for GET list of delivery orders
66c2c04
@ipaullly
[finishes #161773596] add doctsrtings to test class
101cd2c
@ipaullly
[starts #161774149] restructure v1 test folder and write test for sin…
7f1fd34 
…gle order retrieval
@ipaullly
[starts #161777597] Add status attribute and update status method
49471e2
@ipaullly
Create PUT method to cancel order by id
7c66fd9
@ipaullly
[finishes #161777597] write test for PUT cancel order endpoint
d011417
@ipaullly
[starts #161796710] Create authentication blueprint in project directory
e22c523
@ipaullly
create user registration model and registration api
1abc184
@ipaullly
[finishes #161796710] add a test for registration endpoint
5520d68
@ipaullly
write test for registration endpoint and additional logic in its view
0d6055e
@ipaullly
[starts #161820120] Add methods to decode/encode tokens and instance …
0a4cd75 
…folder
@ipaullly
Add enpoint to login and generate token
dcf6e3e
@ipaullly
[finishes #161820120] write minimal tests for sign in endpoint
9e33084
@ipaullly
[starts #161834170]enable continuous integration
71d794e
@ipaullly
add system site package
df4bf08
@ipaullly
corrects the install script
7ca8944
@ipaullly
update .travis.yml file
2be30ed
@ipaullly
travis configuration
4014b58
@ipaullly
travis build correction
f6c7725
@ipaullly
travis build trials
490ff5d
@ipaullly
travis build trials
3197171
@ipaullly
travis build trial
10742fd
@ipaullly
travis build trial
2d3bf80
@ipaullly
[starts #161850180] setup heroku Procfile
d383adb
@ipaullly
add runtime.txt
284ee50
@ipaullly
delete pkg-resources from requirements.txt
c3258f0
@ipaullly
add update pip command to .travis.yml
effae76
@ipaullly
Travis trial 27
52965be
@ipaullly
travis integration trial 29
30b353c
@ipaullly
update README.md
e55316a
@ipaullly
add codecov to .travis.yml
32c468c
@ipaullly
remove pkg-resources==0.0.0
81177dc
@ipaullly
add codecov token
8834aad
@ipaullly
[starts #161911823] add assert statement to check signup endpoint
7571ed0
@ipaullly
edit assertIn args for login/register api tests
290fa14
@ipaullly
[finishes #161911823] add test for empty strings and finish checking …
fe13c7e 
…response messages
@ipaullly
[starts #161920708] create utilities and move decode token function i…
31b405a 
…nto it
@ipaullly
[starts #161921842] add scripts for code climate integration
70898e0
@ipaullly
Try codecov integration
fd2a662
@ipaullly
add coverage xml
42e74bc
@ipaullly
add codecov badge
d9239ca
@ipaullly
[starts #161951629] update README.md with commands to run app locally
b11f21e
@ipaullly
[finishes #161951629] make testing instructions more clear
f65d1c5
@ipaullly
[starts #161954076] Add created order to response of POST request
64d72d4
@ipaullly
[starts #161955974] Add whitespace validation
ec5db7c
@ipaullly
[finishes #161955974] add test for blank email registration
9d74994
@ipaullly
[starts #161957214] Add validation for correct email pattern
360b4fa
@ipaullly
[finishes #161957214] test wrong email pattern
d58860c
@ipaullly
[starts #161966166] add link to API documentation in README.md
fa9b438
@ipaullly
[finishes #161966166] update coverage
2942502
@ipaullly
[starts #161967302] Add validation for parcel id
8b92a37
@ipaullly
[finishes #161967302] test invalid id response
0782e01
@ipaullly
[starts #161980170] Add validation to catch 505 errors when invalid i…
b9262ee 
…d is submitted
@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@0832a2a). Click here to learn what that means.
The diff coverage is 84.44%.

Impacted file tree graph

@@           Coverage Diff           @@
##             develop   #43   +/-   ##
=======================================
  Coverage           ?   85%           
=======================================
  Files              ?    11           
  Lines              ?   280           
  Branches           ?    17           
=======================================
  Hits               ?   238           
  Misses             ?    37           
  Partials           ?     5
Impacted Files Coverage Δ
app/api/v1/__init__.py 100% <100%> (ø)
app/tests/v1/test_login.py 100% <100%> (ø)
app/auth/v1/__init__.py 100% <100%> (ø)
app/api/v1/models.py 100% <100%> (ø)
app/tests/v1/test_register.py 100% <100%> (ø)
app/tests/v1/test_parcels.py 100% <100%> (ø)
app/utilities/validation_functions.py 36.36% <36.36%> (ø)
app/auth/v1/views.py 58.97% <58.97%> (ø)
app/tests/v1/test_edgecases.py 64% <64%> (ø)
app/auth/v1/models.py 84.61% <84.61%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0832a2a...b9262ee. Read the comment docs.

@ipaullly ipaullly merged commit b9262ee into develop Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ipaullly